Patches item #1506645, was opened at 2006-06-15 14:53 Message generated for change (Comment added) made by doerwalter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1506645&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Walter Dörwald (doerwalter) Assigned to: Nobody/Anonymous (nobody) Summary: curses.resizeterm() Initial Comment: This patch add curses.resizeterm() ---------------------------------------------------------------------- >Comment By: Walter Dörwald (doerwalter) Date: 2006-06-19 10:08 Message: Logged In: YES user_id=89016 Checked in a version that does three separate configure checks as r47022. I'll close the patch, once all buildbot have survived the checkin. ---------------------------------------------------------------------- Comment By: Walter Dörwald (doerwalter) Date: 2006-06-19 00:08 Message: Logged In: YES user_id=89016 The man page states: "Most of the work is done by the inner function resize_term. The outer function resizeterm adds bookkeeping for the SIGWINCH handler." All three functions are closely related and are documented on the same man page, so we should be safe with one check. I'll change the macro name and check in the patch tomorrow morning. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2006-06-18 20:21 Message: Logged In: YES user_id=33168 I'm ok with the idea of this patch for 2.5 if you can get in before the freeze. If you do check in, be sure to watch the buildbots. But I have some specific comments/concerns below. A couple of notes about Scott's patch. I would prefer the macro name to be HAVE_CURSES_RESIZETERM. I don't understand why there are 2 variants with and without the _. I see there are 2 different curses APIs. Does the single HAVE_ cover the cases of having is_term_resized, resize_term, and resizeterm? It seems like it might be better to have 2 or 3 configure checks. ---------------------------------------------------------------------- Comment By: Scott Dial (geekmug) Date: 2006-06-17 09:00 Message: Logged In: YES user_id=383208 I have taken the liberty (and my inability to sleep) to update this patch in accordance with the recommendation of a configure check. This version also includes is_term_resized which goes along with the resize[_]term functions. http://scottdial.com/python-dev/curses-resizeterm.diff * It is worthy of note that my version of autoconf seemed to want to quote some things that the trunk version didn't so it perhaps you'd like to run "autoconf" to be safe. ---------------------------------------------------------------------- Comment By: Walter Dörwald (doerwalter) Date: 2006-06-16 09:48 Message: Logged In: YES user_id=89016 Isn't it sufficient that the code is in the #ifdef STRICT_SYSV_CURSES block? ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2006-06-16 07:11 Message: Logged In: YES user_id=21627 AFAICT, Solaris curses does not have resize_term, so you need to add a configure test for it. ---------------------------------------------------------------------- Comment By: Walter Dörwald (doerwalter) Date: 2006-06-15 15:06 Message: Logged In: YES user_id=89016 This second version adds a wrapper for resize_term() too. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1506645&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
