Patches item #1520294, was opened at 2006-07-11 01:45 Message generated for change (Settings changed) made by gbrandl You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1520294&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: Python 2.5 Status: Open Resolution: None Priority: 5 Submitted By: Barry A. Warsaw (bwarsaw) >Assigned to: Barry A. Warsaw (bwarsaw) Summary: Support for PyGetSetDefs in pydoc, inspect, and types Initial Comment: Attributes defined in extension modules via PyGetSetDef aren't instances of property and aren't really handled correctly in the above three modules. This patch adds a types.GetSetterType an inspect.isgetsetter() function, and support for getsetters in pydoc, along with test cases and doc changes. This patch should go into Python 2.5 and part of it should get backported to Python 2.4. Specifically the support for PyGetSetDef in pydoc should be backported, but it should be done in such a way as to not add isgetsetter() or GetSetterType (fairly easy to do as module globals in pydoc.py). Mostly I'm looking for another set of eyes to proof my changes. ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2006-07-11 07:04 Message: Logged In: YES user_id=849994 Why not GetSet? Apart from that, the patch looks fine. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2006-07-11 03:07 Message: Logged In: YES user_id=12800 Yeah, I went back and forth on that a few times. GetSetter was a poor compromise between GetSet and GetterSetter :) ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2006-07-11 02:57 Message: Logged In: YES user_id=33168 I haven't looked at the patch, but the name seems a little funny to me due to the lack of parallel names. GetterSetter makes more sense or the current GetSet. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1520294&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
