Patches item #1524724, was opened at 2006-07-18 13:51 Message generated for change (Comment added) made by tim_one You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1524724&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Build Group: Python 2.5 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Matt Fleming (splitscreen) Assigned to: Nobody/Anonymous (nobody) Summary: Fix --without-threads build error Initial Comment: This patch fixes the compile error reported in #1524317. Please review this patch as I have no idea if it's the right thing to do. Thanks, Matt ---------------------------------------------------------------------- >Comment By: Tim Peters (tim_one) Date: 2006-07-18 20:09 Message: Logged In: YES user_id=31435 Sorry, I didn't notice the change here, and checked in the suggested kind of fix in rev 50708. Unsurprisingly, it's very much like your fix :-) test_sys still fails in a build without threads, but for an unrelated reason. ---------------------------------------------------------------------- Comment By: Matt Fleming (splitscreen) Date: 2006-07-18 15:20 Message: Logged In: YES user_id=1126061 Another patch coming up.. all tests pass for my on Linux with and without threads. ---------------------------------------------------------------------- Comment By: Thomas Heller (theller) Date: 2006-07-18 15:18 Message: Logged In: YES user_id=11105 > I have no idea how to build Python without threads on > Windows, so I'm probably not the best person to try this. Tim, you can uncomment '#define WITH_THREAD' in PC/pyconfig.h, and exclude 'threadmodule.c' from the build, for a start (this will give you the compile error that the patch is supposed to fix, plus others in _ctypes and sqlite3 code, for example ;-). Or you downgrade to linux... ---------------------------------------------------------------------- Comment By: Tim Peters (tim_one) Date: 2006-07-18 14:02 Message: Logged In: YES user_id=31435 The correct way to repair this is to move the body of _PyThread_CurrentFrames above: /* Python "auto thread state" API. */ #ifdef WITH_THREAD _PyThread_CurrentFrames() should be able to return a dict regardless of whether WITH_THREAD is defined. If WITH_THREAD is not defined, sys._current_frames() should return a single-element dict, mapping the integer 0 to the main thread's frame. That should happen "by magic", but the test case will have to be changed to pass then. I have no idea how to build Python without threads on Windows, so I'm probably not the best person to try this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1524724&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
