Patches item #1534084, was opened at 2006-08-03 19:51 Message generated for change (Comment added) made by nascheme You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1534084&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: None >Status: Closed Resolution: Accepted Priority: 9 Submitted By: Neil Schemenauer (nascheme) Assigned to: Neil Schemenauer (nascheme) Summary: Fix code generation bug in 'compiler' package Initial Comment: The compiler package generates invalid code for nested functions (a BUILD_TUPLE opcode is now required). Obviously we need better tests for the package. It would be really nice if this could get fixed before 2.5 is released. ---------------------------------------------------------------------- >Comment By: Neil Schemenauer (nascheme) Date: 2006-08-04 16:20 Message: Logged In: YES user_id=35752 Committed as revision 51109. ---------------------------------------------------------------------- Comment By: Neil Schemenauer (nascheme) Date: 2006-08-04 05:57 Message: Logged In: YES user_id=35752 No, it's not a backport candidate. During the 2.5 development cycle I changed the way the MAKE_CLOSURE opcode worked. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2006-08-04 03:53 Message: Logged In: YES user_id=33168 Good catch! It's always good to see bug fixes which remove code. :-) Please checkin once the the code is unfrozen. It would be good to mention this patch # in the NEWS entry. This is also a backport candidate, isn't it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1534084&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches