Patches item #1533520, was opened at 2006-08-02 23:35 Message generated for change (Comment added) made by splitscreen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1533520&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tests Group: Python 2.5 Status: Open Resolution: None Priority: 5 Submitted By: Matt Fleming (splitscreen) Assigned to: Andrew I MacIntyre (aimacintyre) Summary: Allow thread(ing) tests to pass without setting stack size Initial Comment: This patch changes Lib/test/test_thread.py to use the unit test framework. It also allows platforms that do not support changing the stack size of threads to pass all thread tests. Thanks, Matt ---------------------------------------------------------------------- >Comment By: Matt Fleming (splitscreen) Date: 2006-08-15 15:01 Message: Logged In: YES user_id=1126061 Yes the test was done with an update from trunk as of five minutes before I posted the message. It's probably just a better idea for me to shut up, and we'll resolve this after 2.5? ---------------------------------------------------------------------- Comment By: Andrew I MacIntyre (aimacintyre) Date: 2006-08-15 14:32 Message: Logged In: YES user_id=250749 Sorry, r51133 went in after 2.5b3, but your test would seem to be done with a SVN checkout? As far as I know, the failure you note cannot be resolved without the rewrite to use unittest (or doctest?), which is out of scope until after 2.5 - at least not without removing most of the content of Lib/test/output/test_thread. ---------------------------------------------------------------------- Comment By: Matt Fleming (splitscreen) Date: 2006-08-15 13:45 Message: Logged In: YES user_id=1126061 The test doesn't pass because the output produced from test_thread.py is diffed against Lib/test/output/test_thread Here's the output from running the test test test_thread produced unexpected output: ********************************************************************** *** mismatch between lines 9-18 of expected output and line 9 of actual output: + platform does not support changing thread stack size - caught expected ValueError setting stack_size(4096) - successfully set stack_size(262144) - successfully set stack_size(1048576) - successfully set stack_size(0) - trying stack_size = 262144 - waiting for all tasks to complete - all tasks done - trying stack_size = 1048576 - waiting for all tasks to complete - all tasks done *********************************************** ---------------------------------------------------------------------- Comment By: Andrew I MacIntyre (aimacintyre) Date: 2006-08-15 13:21 Message: Logged In: YES user_id=250749 I should have noted in this item when I checked in rev 51133 that it included the essence of this patch (skipping the thread stack size testing on platfforms that don't support the feature) within the existing test framework. Thus 2.5b3 should correctly handle this situation - if it doesn't, please say so. I understood that it was too late in the 2.5 release process to admit a rewrite and so was waiting for the release to branch before bringing the patch into the trunk. ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2006-08-14 22:12 Message: Logged In: YES user_id=849994 If you get someone else to review the full patch, it's fine with me. ---------------------------------------------------------------------- Comment By: Matt Fleming (splitscreen) Date: 2006-08-14 22:08 Message: Logged In: YES user_id=1126061 Tim Peters expressed that he liked the idea of rewriting the test using the unittest module. However, I can appreciate introducing changes in small steps, so if you reply with a "yes change the tset" I'll have no problem writing another non-unittest patch. Matt ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2006-08-14 21:57 Message: Logged In: YES user_id=849994 For the 2.5 release, could you please post a patch without the conversion to unittest? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1533520&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
