Patches item #1551339, was opened at 2006-09-02 23:48 Message generated for change (Comment added) made by nnorwitz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1551339&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.5 >Status: Closed >Resolution: Accepted Priority: 7 Submitted By: Raymond Hettinger (rhettinger) Assigned to: Neal Norwitz (nnorwitz) Summary: Fix for rpartition() end-case Initial Comment: Per discussion on python-dev ---------------------------------------------------------------------- >Comment By: Neal Norwitz (nnorwitz) Date: 2006-09-04 19:21 Message: Logged In: YES user_id=33168 This patch is different than what's on HEAD (some files, in particular partition.h and string_tests.py). HEAD passes, this one doesn't. I'm using the version from head. Committed revision 51718. ---------------------------------------------------------------------- Comment By: Raymond Hettinger (rhettinger) Date: 2006-09-04 15:20 Message: Logged In: YES user_id=80475 Neal, please move this from the head to the release branch when you're ready. Nick, thanks for the review. ---------------------------------------------------------------------- Comment By: Nick Coghlan (ncoghlan) Date: 2006-09-04 06:07 Message: Logged In: YES user_id=1038590 Aside from the tests, the patch looks OK. (A search through the standard library showed that the only current use of rpartition() is in UserString.py, which will correctly inherit the behaviour of the underlying string type). For the tests, the degenerate cases are already tested (second test in each group), so new test cases aren't necessary. Instead, the expected result for the degenerate rpartition test needs to be updated. (Also, the second test case added by the patch invoked partition() instead of rpartition()) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1551339&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
