Patches item #1578999, was opened at 2006-10-17 16:27 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1578999&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Macintosh Group: None Status: Open Resolution: None Priority: 5 Submitted By: Martin v. Löwis (loewis) Assigned to: Jack Jansen (jackjansen) Summary: PyArg_ParseTuple corrections Initial Comment: The attached patch corrects a number of errors in the usage of PyErr_Format, for the Mac specific modules. It should be reviewed for technical correctness wrt. the Apple API, and also wrt. whether the patch changes generated files. In particular, the error corrections are: - OSErr is a 16-bit value, can't parse with 'i' - MusicMIDIPacket::data is UINT8[249], parsing it with s# won't work, as s# outputs a char*. I *assume* QtMusicMIDIPacket_Convert wants to get the string into the data buffer - In Qt_TuneSetHeader, an int* is passed to an 's' argument. Not sure whether this is correct: shouldn't there be a requirement that the string is a multiple of sizeof(int) in length? - SndCmd_Convert parses a char* into a long. This is correct in terms of size for both 32-bit and 64-bit systems. Is it also correct logically? (i.e. is param2 really a pointer?) - TXNScrollBarState is a single-byte type - ScrapFlavorFlags is an unsigned type - Boolean is a single-byte type - CFStringEncoding is now parsed through a long temporary variable, as it's not clear what format code would be correct ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2006-10-17 16:28 Message: Logged In: YES user_id=21627 PyArg_ParseTuple, I mean, not PyErr_Format. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1578999&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
