Patches item #1549049, was opened at 2006-08-30 06:50 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1549049&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.5 >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Roger Upole (rupole) Assigned to: Nobody/Anonymous (nobody) Summary: Fix for structmember conversion issues Initial Comment: This patch is for bug# 1545696. Patches created against 2.5c1. ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2006-10-27 08:19 Message: Logged In: YES user_id=21627 Thanks for the patch. I committed it, with modifications, as r52452 for the trunk, and r52453 for the 2.5 branch. In the 2.5 branch, I removed the warnings. Please review my changes to find out errors I may have made. ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2006-10-27 08:02 Message: Logged In: YES user_id=21627 A few comments: - the truncation of float values should not cause a warning. float values will always be truncated (i.e. lose precision) when written to T_FLOAT; there's really no way to avoid that. - that PyObject_HEAD_INIT can sometimes be used is because these initializations occur within the same DLL (pythonxy.dll). It is cross-DLL access to addresses of global variables which Windows doesn't support. - I restored support for passing negative values into T_UINT/T_ULONG ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1549049&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
