Patches item #1589070, was opened at 2006-11-02 06:44
Message generated for change (Settings changed) made by ronaldoussoren
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1589070&group_id=5470
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Macintosh
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Humberto Di�genes (virtualspirit)
Assigned to: Ronald Oussoren (ronaldoussoren)
Summary: MacPython Build Installer - Typos and Style corrections
Initial Comment:
* Corrected many typos (such as "IDLE is an IDLE" instead of "IDLE is an
IDE");
* Simplified SRCDIR guessing;
* PEP8 style;
Includes patch #1589013 ("Univeral" MacPython).
----------------------------------------------------------------------
>Comment By: Ronald Oussoren (ronaldoussoren)
Date: 2006-11-07 17:01
Message:
Logged In: YES
user_id=580910
I've commited the typo fixes as 52644 (trunk), 52645 (2.5 branch), 52646 (2.4
branch). The PEP8 style changes were applied in revision 52647
on the trunk.
----------------------------------------------------------------------
Comment By: Humberto Di�genes (virtualspirit)
Date: 2006-11-07 16:55
Message:
Logged In: YES
user_id=736405
Yes, after Jack's comment I noticed it was a really bad idea to mix these
changes. Thanks for accepting it anyway! :)
----------------------------------------------------------------------
Comment By: Ronald Oussoren (ronaldoussoren)
Date: 2006-11-07 16:37
Message:
Logged In: YES
user_id=580910
The change to SRCDIR looks bogus and even if it works I find the current
version more readable. That will definitely not go in.
I will apply the typo fixes, and may do the same with the style changes.
BTW. Humberto, it would be better to split the formatting changes from
functional changes in future patches. We now had to hunt down the
patch fragments that weren't formatting changes. Anyway, thanks for the patch.
----------------------------------------------------------------------
Comment By: Jack Jansen (jackjansen)
Date: 2006-11-02 13:51
Message:
Logged In: YES
user_id=45365
Ronald, aside from a number of typo fixes (it took me 5 minutes to see that
there's an "s" missing in "Univeral MacPython" :-) there's also some
changes in the logic; those probably need some eyeballing over (the changes to
SRCDIR look a bit suspect).
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1589070&group_id=5470
_______________________________________________
Patches mailing list
[email protected]
http://mail.python.org/mailman/listinfo/patches
