Patches item #1076826, was opened at 2004-12-01 16:32 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1076826&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: Python 2.4 >Status: Closed >Resolution: Out of Date Priority: 5 Private: No Submitted By: Michal Čihař (nijel) Assigned to: Nobody/Anonymous (nobody) Summary: readline does not need termcap Initial Comment: Readline doesn't need -ltermcap (at least on some systems), so configure check should deal with this. Attached patch completely removes -ltermcap, however better might be to check both possibilities. Patch is against 2.3.3, however it applies to 2.4 also. ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2006-11-22 09:58 Message: Logged In: YES user_id=21627 Originator: NO I think this patch is obsolete since r41945; closing it as out-of-date. ---------------------------------------------------------------------- Comment By: Michal Čihař (nijel) Date: 2004-12-06 23:48 Message: Logged In: YES user_id=192186 Ooops, I should better read what I write, there shouldn't be twice ncurses, once it should be termcap.... Sorry. ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2004-12-06 23:29 Message: Logged In: YES user_id=21627 This patch is still incorrect. It breaks on systems where readline requires termcap, e.g. Solaris. ---------------------------------------------------------------------- Comment By: Michal Čihař (nijel) Date: 2004-12-06 12:18 Message: Logged In: YES user_id=192186 Okay, here is IMHO correct patch, which does more or less same as setup.py does for finding needed libraries. ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2004-12-05 19:59 Message: Logged In: YES user_id=21627 The patch is incorrect. As you suggest yourself, readline *does* need -ltermcap on some systems; this patch breaks these systems. Rejecting the patch. If you can come up with a patch that performs an autoconf test first, please submit a new patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1076826&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
