Patches item #1432399, was opened at 2006-02-15 20:26 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1432399&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Modules Group: Python 2.4 >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Philippe Biondi (drphil) Assigned to: Nobody/Anonymous (nobody) Summary: Missing HCI sockets in bluetooth code from socketmodule Initial Comment: Bluetooth code in socketmodule does not implement BTPROTO_HCI. This small patch adds the missing code. ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2007-02-14 11:10 Message: Logged In: YES user_id=21627 Originator: NO Thanks for the patch, I committed it as r53774. I made a few modifications, like adding the return statement and guessing what the NetBSD support could be; I was not able to test any of this. As for documentation and test suite changes: I'm willing to waive them. The bluetooth sockets are not documented at all so far, and testing them would only be possible if you have the hardware. I guess users will tell us if this is correct or whether something is missing. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2006-03-14 08:45 Message: Logged In: YES user_id=33168 This patch is missing a return 1; in case BTPROTO_HCI: around line 1310. I don't know if there are other problems or if this code is portable. There are no tests or doc updates. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1432399&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
