Patches item #1144504, was opened at 2005-02-19 21:02 Message generated for change (Comment added) made by loewis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1144504&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Modules Group: Python 2.3 >Status: Closed >Resolution: Rejected Priority: 5 Private: No Submitted By: Ben Schwartz (bensatmit_edu) Assigned to: Nobody/Anonymous (nobody) Summary: Add IEEE Float support to wave.py Initial Comment: IEEE Float .wav files have almost identical structure to standard PCM .wav files. Currently, wave.py gives an unknown format error when attempting to read IEEE Float .wav files. This patch causes wave.py to read those files properly. No changes were made to wave_write, only wave_read. ---------------------------------------------------------------------- >Comment By: Martin v. Löwis (loewis) Date: 2007-02-14 11:17 Message: Logged In: YES user_id=21627 Originator: NO Since there was no follow-up to Andrew's remark that the patch is incorrect, I conclude that the submitter either lost interest in it, or agrees that the patch is indeed incorrect. Rejecting it as invalid. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2005-11-22 19:54 Message: Logged In: YES user_id=11375 Looking at the WAV format description at http://ccrma.stanford.edu/CCRMA/Courses/422/projects/WaveFormat , it looks like the patch isn't correct. There's an ExtraParams field after the header that's only present if the format is not PCM. If this is correct, the patch should also add code to read this field and either store it somewhere or just discard it. ---------------------------------------------------------------------- Comment By: Michael Chermside (mcherm) Date: 2005-02-23 14:11 Message: Logged In: YES user_id=99874 I don't know anything about the .wav format, but the patch is particularly inoffensive... it simply allows a second format constant in the WAVE header without raising an error. I recomend applying the patch as soon as someone else who DOES know the .wav format can confirm that it's being done right. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1144504&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
