Patches item #1654417, was opened at 2007-02-07 17:58 Message generated for change (Comment added) made by gbrandl You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1654417&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Andy Wingo (wingo) Assigned to: Nobody/Anonymous (nobody) Summary: operator.c slice functions need to parse ssize_t Initial Comment: To reproduce, on a system with 64 bits in sys.maxint: $ python x = [3,4,5] del x[1:] x = [3,4,5] from operator import delslice import sys delslice(x, 1, sys.maxint) Traceback (most recent call last): File "<stdin>", line 1, in <module> OverflowError: signed integer is greater than maximum ---------------------------------------------------------------------- >Comment By: Georg Brandl (gbrandl) Date: 2007-03-06 19:00 Message: Logged In: YES user_id=849994 Originator: NO Committed as rev. 54177, 54178 (2.5). ---------------------------------------------------------------------- Comment By: Andy Wingo (wingo) Date: 2007-03-06 16:15 Message: Logged In: YES user_id=268660 Originator: YES Updated the patch, thanks for the tests, zseil. ---------------------------------------------------------------------- Comment By: Andy Wingo (wingo) Date: 2007-03-06 16:15 Message: Logged In: YES user_id=268660 Originator: YES File Added: operator_slice.diff ---------------------------------------------------------------------- Comment By: Žiga Seilnacht (zseil) Date: 2007-03-06 16:04 Message: Logged In: YES user_id=1326842 Originator: NO The patch looks correct to me, but I can't test it since I don't have a 64 bit system. I posted the patch with added tests here: http://freeweb.siol.net/chollus/ Can someone with the right privileges attach that file here? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1654417&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
