Patches item #728815, was opened at 2003-04-28 12:21
Message generated for change (Comment added) made by sonderblade
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=728815&group_id=5470
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tests
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Dmitry Vasiliev (hdima)
Assigned to: Nobody/Anonymous (nobody)
Summary: test_timeout updates
Initial Comment:
Changes:
- code refactoring;
- now we catch only exceptions with proper errno codes
(also see bug #708927);
- addr_remote changed, ('www.google.com', 80) not
always works for me since we use transparent proxy;
- attempt to implement testSend(), testSendto(),
testSendall();
----------------------------------------------------------------------
Comment By: Bj�rn Lindqvist (sonderblade)
Date: 2007-03-10 01:52
Message:
Logged In: YES
user_id=51702
Originator: NO
I have created a patch that I hope can supersede this one. This patch
does some nice refactorings to test_timeout.py by encapsulating some
common code in a sockOperation method. Then that method is used to run
the function under test. It also implements tests for testSend,
testSendto and testSendall. Plus, (I think) it fixes a bug which (I
think) only happens when you access the internet from behind a web
proxy.
I think the patch is good but there were two problems with it so I
created a new one. First, it tries to filter out errors dealing with
timeouts from normal socket.error's. But the author forgot about args
with only one string as a value. Second, I do not like how the actual
assertion of the test is done in the tearDown method.
My patch fixes those problems, otherwise it is mostly identical to
this patch. It is #1677694 at
http://sourceforge.net/tracker/index.php?func=detail&aid=1677694&group_id=5470&atid=105470
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2006-04-14 18:10
Message:
Logged In: YES
user_id=21627
rhettinger: would you like to review it now? If not, please
unassign.
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2003-06-30 16:52
Message:
Logged In: YES
user_id=80475
I'll give it more review.
Since Py2.3b2 is out, I'm marking this as a change for Py2.4
and we can apply it in early August.
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2003-06-30 16:52
Message:
Logged In: YES
user_id=80475
I'll give it more review.
Since Py2.3b2 is out, I'm marking this as a change for Py2.4
and we can apply it in early August.
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2003-06-30 16:52
Message:
Logged In: YES
user_id=80475
I'll give it more review.
Since Py2.3b2 is out, I'm marking this as a change for Py2.4
and we can apply it in early August.
----------------------------------------------------------------------
Comment By: Walter Dörwald (doerwalter)
Date: 2003-06-30 14:37
Message:
Logged In: YES
user_id=89016
I'm no expert in socket programming, so the final decision
whether this is OK is your's.
----------------------------------------------------------------------
Comment By: Raymond Hettinger (rhettinger)
Date: 2003-06-28 16:09
Message:
Logged In: YES
user_id=80475
Walter, are you interested in working this patch?
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=728815&group_id=5470
_______________________________________________
Patches mailing list
Patches@python.org
http://mail.python.org/mailman/listinfo/patches
