Patches item #1009811, was opened at 2004-08-16 01:00 Message generated for change (Comment added) made by foom You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1009811&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.4 Status: Closed Resolution: Postponed Priority: 5 Private: No Submitted By: James Y Knight (foom) Assigned to: Nobody/Anonymous (nobody) Summary: Add missing types to __builtin__ Initial Comment: Add most of the missing type objects to __builtin__. Adds the following: ellipsis (not to be confused with Ellipsis, which is the object of this type) builtin_function_or_method dictproxy generator PyCObject classobj instance instancemethod cell NoneType NotImplementedType frame function module traceback code Does not add the rest of the names mentioned in my email, as I'm unsure if they got an approval or were silently ignored. I'm not convinced that it's a good idea to put the rest in __builtin__, myself. See also: <http://mail.python.org/pipermail/python-dev/2004-August/ 047754.html> and <http://mail.python.org/pipermail/python-dev/2004-August/ 047830.html> ---------------------------------------------------------------------- >Comment By: James Y Knight (foom) Date: 2007-03-11 19:47 Message: Logged In: YES user_id=1104715 Originator: YES I only submitted this because I was directed to. To reiterate, the actual problem is that the classes claim to be defined in a place they aren't actually defined in. Quoting myself: Sooo should (for 'generator' in objects that claim to be in __builtin__ but aren't), 1) 'generator' be added to __builtin__ 2) 'generator' be added to types.py and its __module__ be set to 'types' 3) 'generator' be added to <newmodule>.py and its __module__ be set to '<newmodule>' (and a name for the module chosen) Me, I'm pretty much agnostic towards which solution is chosen, and if this one isn't it, fine with me. I just want to see python be truthful about where types are defined, whatever form that takes. ---------------------------------------------------------------------- Comment By: Collin Winter (collinwinter) Date: 2007-03-11 14:39 Message: Logged In: YES user_id=1344176 Originator: NO I agree with Martin. This is going to be taken care of in Python 3 (somehow) regardless. ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2005-01-27 01:20 Message: Logged In: YES user_id=21627 I don't like to see further __builtin__ pollution, so I recommend to reject this patch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1009811&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
