Patches item #1623563, was opened at 2006-12-28 12:48 Message generated for change (Comment added) made by zseil You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1623563&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.6 Status: Open Resolution: None Priority: 5 Private: No Submitted By: TH (therve) Assigned to: Nobody/Anonymous (nobody) Summary: Allow __class __ assignment for classes with __slots__ Initial Comment: I made a modification in typeobject.c to allow __class__ modification for classes with slots. It's basically a change in same_slots_added to count the offset of the slots and check if the names of the slots are the same (in the naive way). I don't check if slots are in a different order, that may be an improve. The patch is against trunk, with some tests. It's my first submission on Python, so every feedback will be welcome :). ---------------------------------------------------------------------- >Comment By: Žiga Seilnacht (zseil) Date: 2007-03-13 17:16 Message: Logged In: YES user_id=1326842 Originator: NO The only problem that I see with this patch is that slot names have to be listed in both classes in the same order for __class__ assignment to work. This could have strange consequences when a dict is used for __slots__. I'm attaching a patch that fixes this, with modified test and documentation. The change had to be done in type_new() function, by sorting slotnames before the creation of member descriptors. Most of the documentation changes are whitespace cleanup. File Added: same_slots_added_4.diff ---------------------------------------------------------------------- Comment By: TH (therve) Date: 2007-03-08 14:08 Message: Logged In: YES user_id=1038797 Originator: YES File Added: same_slots_added_3.diff ---------------------------------------------------------------------- Comment By: Žiga Seilnacht (zseil) Date: 2007-03-07 18:07 Message: Logged In: YES user_id=1326842 Originator: NO The PyObject * cast is reduntant, but otherwise the patch looks good to me. I added a few more tests, but I can't attach a file so I posted them here: http://freeweb.siol.net/chollus/ ---------------------------------------------------------------------- Comment By: TH (therve) Date: 2007-03-07 14:05 Message: Logged In: YES user_id=1038797 Originator: YES Thanks, I wasn't able to find this function. I updated the patch for using this. File Added: same_slots_added_2.diff ---------------------------------------------------------------------- Comment By: TH (therve) Date: 2007-03-07 14:04 Message: Logged In: YES user_id=1038797 Originator: YES File Added: same_slots_added_2.diff ---------------------------------------------------------------------- Comment By: Žiga Seilnacht (zseil) Date: 2007-03-06 19:07 Message: Logged In: YES user_id=1326842 Originator: NO You should use _PyString_Eq() for string comparison instead of relying on the internal details of PyStringObject. ---------------------------------------------------------------------- Comment By: Jim Jewett (jimjjewett) Date: 2007-02-08 19:41 Message: Logged In: YES user_id=764593 Originator: NO Review five other patches. Post the review summaries (and tracker numbers) to the python-dev mailing list. In that same message, ask someone with commit privileges to do the 5:1 deal, pointing at this tracker number. ---------------------------------------------------------------------- Comment By: TH (therve) Date: 2007-02-06 14:43 Message: Logged In: YES user_id=1038797 Originator: YES Is there anything I can do to have a resolution on this ? Thanks. ---------------------------------------------------------------------- Comment By: Jim Jewett (jimjjewett) Date: 2006-12-31 01:26 Message: Logged In: YES user_id=764593 Originator: NO Just going through the list doesn't seem so naive to me. If the slots are in a different order, then you would need to move the data around -- which borders on "maybe they ought to have written the translator themselves" ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1623563&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
