Patches item #1635639, was opened at 2007-01-15 07:43
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1635639&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Python 2.6
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Mark Roberts (mark-roberts)
Assigned to: Nobody/Anonymous (nobody)
Summary: ConfigParser does not quote %

Initial Comment:
This is covered by bug 1603688 
(https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1603688&group_id=5470)

I implemented 2 versions of this patch.  One version raises ValueError when an 
invalid interpolation syntax is encountered (such as foo%, foo%bar, and %foo, 
but not %%foo and %(dir)foo).

The other version simply replaces appropriate %s with %%s.

Initially, I believed ValueError was the appropriate way to go with this.  
However, when I thought about how I use ConfigParser, I realized that it would 
be far nicer if it simply worked.

I'm +0.5 to ValueError, and +1 to munging the values.

----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2007-03-13 17:44

Message:
Logged In: YES 
user_id=849994
Originator: NO

Explicit is better than implicit.
I committed a similar patch that raises ValueError, and your new test
cases in rev. 54339.

----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2007-01-22 19:44

Message:
Logged In: YES 
user_id=11375
Originator: NO

Turning into a patch.

----------------------------------------------------------------------

Comment By: Mark Roberts (mark-roberts)
Date: 2007-01-16 02:17

Message:
Logged In: YES 
user_id=1591633
Originator: YES

For the record, this was supposed to be a patch.  I don't know if the
admins have any way of moving it to that category.  I guess that explained
the funky categories and groups.  Sorry for the inconvenience.

----------------------------------------------------------------------

Comment By: Mark Roberts (mark-roberts)
Date: 2007-01-15 07:44

Message:
Logged In: YES 
user_id=1591633
Originator: YES

File Added: bug_1603688_cfgparser_munges.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1635639&group_id=5470
_______________________________________________
Patches mailing list
Patches@python.org
http://mail.python.org/mailman/listinfo/patches

Reply via email to