Patches item #1680961, was opened at 2007-03-14 19:51
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1680961&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 3000
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Georg Brandl (gbrandl)
Assigned to: Nobody/Anonymous (nobody)
Summary: remove sys.exitfunc, rewrite atexit in C

Initial Comment:
This removes sys.exitfunc. atexit is rewritten in C and uses as much of the 
existing sys.exitfunc-infrastructure (which is renamed).

----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2007-03-14 22:30

Message:
Logged In: YES 
user_id=849994
Originator: YES

Note that the patch is against the p3yk branch.

Note also that, without changing Modules/Setup, the new module won't be
built and used.
In fact, the test suite doesn't pass with it since I haven't updated the
tests that
depend on atexit._exithandlers.

But thanks for reviewing nonetheless!

----------------------------------------------------------------------

Comment By: Alan McIntyre (alanmcintyre)
Date: 2007-03-14 21:30

Message:
Logged In: YES 
user_id=1115903
Originator: NO

The attached patch didn't apply cleanly for me; the hunk that removes
call_sys_exitfunc (pythonrun.c) failed, but everything else applied just
fine.  I removed call_sys_exitfunc manually and then everything compiled
and passes regrtest.py (with -r -u all) with no unexpected skips (Linux). 


The docs also build just fine and I don't see any grammatical/formatting
errors or anything that jumps out as a technical error (but I'm not all
that familiar with atexit/exitfunc, so take my endorsement with a grain of
salt ;).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1680961&group_id=5470
_______________________________________________
Patches mailing list
Patches@python.org
http://mail.python.org/mailman/listinfo/patches

Reply via email to