Patches item #1197318, was opened at 2005-05-07 17:56 Message generated for change (Comment added) made by zseil You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1197318&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.5 >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Jason Tishler (jlt63) Assigned to: Jason Tishler (jlt63) Summary: Cygwin case-sensitive import patch Initial Comment: A problem regarding importing symlinked modules was recently reported on the Cygwin mailing list: http://cygwin.com/ml/cygwin/2005-04/msg00257.html The following test case demonstrates the problem: $ ls -l total 1 lrwxrwxrwx 1 jt None 6 Apr 23 13:32 bar.py -> foo.py -rw-r--r-- 1 jt None 24 Apr 18 20:13 foo.py $ python -c 'import bar' Traceback (most recent call last): File "<string>", line 1, in ? ImportError: No module named bar Since Cygwin's case_ok() uses a modified version of the Windows's version, the symlinked bar module actually resolves to file foo.py instead of bar.py. This obviously causes the matching code to fail (regardless of case). The attached patch fixes this problem. All that it does it make Cygwin use the Mac OS X case_ok() instead of a modified Window's version. Is this OK to apply? Or, would someone like to make sure I didn't break the Windows and Mac builds first? AFAICT, I didn't, but you never know... :,) Additionally, can I apply this patch to the 2.4 maintence branch? If so, is "release24-maint" the correct CVS tag to use? Thanks. ---------------------------------------------------------------------- >Comment By: Žiga Seilnacht (zseil) Date: 2007-04-02 11:54 Message: Logged In: YES user_id=1326842 Originator: NO The 2.4 branch is not maintained anymore, so this patch can be closed. The patch is included in Python 2.5. ---------------------------------------------------------------------- Comment By: Jason Tishler (jlt63) Date: 2005-05-20 03:06 Message: Logged In: YES user_id=86216 Commited onto HEAD as Python/import.c 2.241, so I'm in forgiveness mode for this change... :,) However, I won't commit onto the maintence branch without explicit permission, so I'm still in permission mode for this one... :,) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1197318&group_id=5470 _______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
