Patches item #1711603, was opened at 2007-05-02 19:12
Message generated for change (Comment added) made by luke-jr
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1711603&group_id=5470
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Luke-Jr (luke-jr)
Assigned to: Nobody/Anonymous (nobody)
Summary: syslog syscall support for SysLogLogger
Initial Comment:
This allows SysLogLogger to be used via the normal syslog syscall.
----------------------------------------------------------------------
>Comment By: Luke-Jr (luke-jr)
Date: 2007-05-10 10:09
Message:
Logged In: YES
user_id=25634
Originator: YES
No, 'syslog' wouldn't work because the running program's name is not
'syslog'. It should be the same name as appears in the process list, which
is argv[0]
----------------------------------------------------------------------
Comment By: jos (josm)
Date: 2007-05-10 07:31
Message:
Logged In: YES
user_id=1776568
Originator: NO
Sorry, I quoted wrong PEP... PEP 7 is for C code, not Python's one.
PEP 8 is right guide.
I'm still wondering whether using sys.argv[0] for default value is valid
or not.
How about changing this as ident = 'syslog'?
doesn't that work?
----------------------------------------------------------------------
Comment By: Luke-Jr (luke-jr)
Date: 2007-05-06 11:14
Message:
Logged In: YES
user_id=25634
Originator: YES
File Added: SysLogHandler-syslog-0.04.patch
----------------------------------------------------------------------
Comment By: Luke-Jr (luke-jr)
Date: 2007-05-06 11:05
Message:
Logged In: YES
user_id=25634
Originator: YES
The 'ident' value is normally the name of the program, which should be
argv[0]. I prefer and normally use single-tab indents. However, when
patching code, I adjust to the existing standard within the source. In this
case, my handlers.py was already indented with spaces so I conformed to
that. I glanced at svn before posting this, and it doesn't appear to be
much different for this file.
----------------------------------------------------------------------
Comment By: jos (josm)
Date: 2007-05-06 04:58
Message:
Logged In: YES
user_id=1776568
Originator: NO
Thank you for your reply.
A few more comments and requests.
+ def __init__(self, address=('localhost', SYSLOG_UDP_PORT),
facility=LOG_USER, ident=sys.argv[0]):
Why sys.argv[0]? Assuming command line arguments doesn't look reasonable
to me.
+ self.unixsocket = 0
+ self.syscall = 0
Please use single-tab indents. (PEP7)
Can I have the patch patch against the svn repository?
(against trunk should be preferable)
I had some problem applying your patch.
----------------------------------------------------------------------
Comment By: Luke-Jr (luke-jr)
Date: 2007-05-05 12:28
Message:
Logged In: YES
user_id=25634
Originator: YES
Not all syslog daemons accept socket connections. For example, metalog.
----------------------------------------------------------------------
Comment By: jos (josm)
Date: 2007-05-05 08:25
Message:
Logged In: YES
user_id=1776568
Originator: NO
What advantage does OS's syslog have over the logging module's one?
I've never been familiar with syslog,
So could you please tell me the difference?
----------------------------------------------------------------------
Comment By: Luke-Jr (luke-jr)
Date: 2007-05-02 19:22
Message:
Logged In: YES
user_id=25634
Originator: YES
File Added: SysLogHandler-syslog-0.03.patch
----------------------------------------------------------------------
Comment By: Luke-Jr (luke-jr)
Date: 2007-05-02 19:14
Message:
Logged In: YES
user_id=25634
Originator: YES
File Added: SysLogHandler-syslog-0.02.patch
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1711603&group_id=5470
_______________________________________________
Patches mailing list
Patches@python.org
http://mail.python.org/mailman/listinfo/patches
