Patches item #1526367, was opened at 2006-07-21 04:39 Message generated for change (Comment added) made by rhettinger You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1526367&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Python 2.6 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Walter Dörwald (doerwalter) Assigned to: Nobody/Anonymous (nobody) Summary: str.__iter__ and unicode.__iter__ Initial Comment: This patch add iterator classes for str and unicode, as discussed here: http://mail.python.org/pipermail/python-3000/2006-July/002650.html ---------------------------------------------------------------------- >Comment By: Raymond Hettinger (rhettinger) Date: 2007-06-05 17:21 Message: Logged In: YES user_id=80475 Originator: NO What is the point of this patch for Py2.6? There is nothing broken here. Not every sequence needs it's own __iter__. That is provided automatically. I intentionally left-out strings from when I added __iter__ to tuples, lists, and dicts. There was no compelling speed benefit as there was for the other objects. ---------------------------------------------------------------------- Comment By: Bj�rn Lindqvist (sonderblade) Date: 2007-06-05 16:43 Message: Logged In: YES user_id=51702 Originator: NO Patch applies cleanly and works as expected (str.__iter__, unicode.__iter__) and all tests pass. ---------------------------------------------------------------------- Comment By: Walter Dörwald (doerwalter) Date: 2007-03-17 11:55 Message: Logged In: YES user_id=89016 Originator: YES Code coverage is pretty good without any new tests (see <http://styx.livinglogic.de/~walter/python/unicodeobject.c.gcov>) The only function uncovered is unicodeiter_len (striter_len). I've added a test for this to the new version of the patch (diff2.txt). File Added: diff2.txt ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2007-03-13 14:41 Message: Logged In: YES user_id=849994 Originator: NO This looks good, but needs new tests. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1526367&group_id=5470
_______________________________________________ Patches mailing list [email protected] http://mail.python.org/mailman/listinfo/patches
