Patches item #1734346, was opened at 2007-06-10 14:53 Message generated for change (Comment added) made by snaury You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1734346&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alexey Borzenkov (snaury) Assigned to: Nobody/Anonymous (nobody) Summary: patch for bug 1170311 "zipfile UnicodeDecodeError" Initial Comment: This patch fixes UnicodeDecodeError when attempting to write files to zipfile with filename of unicode class. ---------------------------------------------------------------------- >Comment By: Alexey Borzenkov (snaury) Date: 2007-06-11 00:29 Message: Logged In: YES user_id=1197042 Originator: YES File Added: python-zipfile-unicode-filenames-utf8.patch ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2007-06-10 20:48 Message: Logged In: YES user_id=21627 Originator: NO This patch is incorrect. It relies on the system encoding, and allows non-string things as file names. What it really should do is to encode in code page 437; bonus points if it falls back to the UTF-8 feature of zip files when that encoding fails. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1734346&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches