Patches item #1735030, was opened at 2007-06-11 16:06 Message generated for change (Comment added) made by mbanck You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1735030&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Michael Banck (mbanck) Assigned to: Nobody/Anonymous (nobody) Summary: Fix selectmodule.c compilation on GNU/Hurd Initial Comment: This patch (by Wouter van Heyst) fixes compilation of python2.5 on the Hurd (and other systems?) It fixes the following build error: gcc -fPIC -fno-strict-aliasing -DNDEBUG -g -O3 -Wall -Wstrict-prototypes -I. -I/build/buildd/python2.5-2.5/./Include -I../Include -I. -I/build/buildd/python2.5-2.5/Include -I/build/buildd/python2.5-2.5/build-static -c /build/buildd/python2.5-2.5/Modules/selectmodule.c -o build/temp.gnu-0.3-i686-AT386-2.5/build/buildd/python2.5-2.5/Modules/selectmodule.o /build/buildd/python2.5-2.5/Modules/selectmodule.c:676: error: 'select_poll' undeclared here (not in a function) /build/buildd/python2.5-2.5/Modules/selectmodule.c:676: error: 'poll_doc' undeclared here (not in a function) /build/buildd/python2.5-2.5/Modules/selectmodule.c: In function 'initselect': /build/buildd/python2.5-2.5/Modules/selectmodule.c:709: error: 'poll_Type' undeclared (first use in this function) /build/buildd/python2.5-2.5/Modules/selectmodule.c:709: error: (Each undeclared identifier is reported only once /build/buildd/python2.5-2.5/Modules/selectmodule.c:709: error: for each function it appears in.) /build/buildd/python2.5-2.5/Modules/selectmodule.c:709: error: request for member 'ob_type' in something not a structure or union /build/buildd/python2.5-2.5/Modules/selectmodule.c:709: warning: statement with no effect We hope this does not break other platforms, does this look OK? ---------------------------------------------------------------------- >Comment By: Michael Banck (mbanck) Date: 2007-06-28 18:09 Message: Logged In: YES user_id=196016 Originator: YES Hrm, upon further analysis, it looks likely that poll() really is not conforming to POSIX on GNU/Hurd and should get fixed, rather than HAVE_BROKEN_POLL code be changed. I have submitted this upstream to the Hurd developers, the patch should not be applied in the meantime (and might be obsolete). ---------------------------------------------------------------------- Comment By: Michael Banck (mbanck) Date: 2007-06-12 14:55 Message: Logged In: YES user_id=196016 Originator: YES Yes, python2.5 builds fine otherwise (at least the Debian package, I am not sure whether we applied local changes earlier). This HAVE_BROKEN_POLL issue was the only regression from python2.4 as far as the Debian GNU/Hurd port was concerned. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2007-06-12 04:54 Message: Logged In: YES user_id=33168 Originator: NO Is this only change required for Hurd? I'm not sure, but HAVE_BROKEN_POLL might have a specific meaning on OS X. So there might be a problem with this patch. I'd need to look at the whole file to verify. I'll try to remember to do that later. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1735030&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
