Patches item #1751515, was opened at 2007-07-10 18:25 Message generated for change (Comment added) made by gvanrossum You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1751515&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tests Group: Python 3000 >Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Christian Heimes (tiran) >Assigned to: Guido van Rossum (gvanrossum) Summary: struni: Replace assert_(==) with failUnlessEqual Initial Comment: Patch for py3k-struni branch It replaces assert_(foo == bar) and failUnless(foo == bar) with failUnlessEqual(foo, bar). It makes debugging the error MUCH easier to see both values. ---------------------------------------------------------------------- >Comment By: Guido van Rossum (gvanrossum) Date: 2007-07-11 08:27 Message: Logged In: YES user_id=6380 Originator: NO Sorry, that was meant for another patch. I've checked this one in now, after changing failUnlessEqual with assertEqual (the double negative trips me up in reading code using failUnlessXXX all the time). ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2007-07-11 08:11 Message: Logged In: YES user_id=6380 Originator: NO check it in! ---------------------------------------------------------------------- Comment By: Christian Heimes (tiran) Date: 2007-07-10 20:01 Message: Logged In: YES user_id=560817 Originator: YES File Added: newpatch.diff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1751515&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
