Patches item #1673759, was opened at 2007-03-05 02:45 Message generated for change (Comment added) made by gbrandl You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1673759&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.5 >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Eric V. Smith (ericvsmith) Assigned to: Nobody/Anonymous (nobody) Summary: '%G' string formatting doesn't catch same errors as '%g' Initial Comment: See http://python.org/sf/1673757 ---------------------------------------------------------------------- >Comment By: Georg Brandl (gbrandl) Date: 2007-07-12 08:39 Message: Logged In: YES user_id=849994 Originator: NO Committed in rev. 56298, 56299 (2.5). ---------------------------------------------------------------------- Comment By: Bj�rn Lindqvist (sonderblade) Date: 2007-06-04 23:11 Message: Logged In: YES user_id=51702 Originator: NO Shouldn't this be committed now? ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2007-03-18 03:57 Message: Logged In: YES user_id=6380 Originator: NO Changing the category to 2.5; since the bug appears in 2.5 and 2.6, this should be applied to 2.5 and to the trunk (i.e. 2.6) and then it will automatically be merged into 3.0 when the next merge is done. ---------------------------------------------------------------------- Comment By: Paul Hankin (paulhankin) Date: 2007-03-10 21:50 Message: Logged In: YES user_id=1740099 Originator: NO lgtm ---------------------------------------------------------------------- Comment By: Eric V. Smith (ericvsmith) Date: 2007-03-10 18:58 Message: Logged In: YES user_id=411198 Originator: YES Improved summary. ---------------------------------------------------------------------- Comment By: Eric V. Smith (ericvsmith) Date: 2007-03-10 18:57 Message: Logged In: YES user_id=411198 Originator: YES Thanks for the catch on the line length. I've updated the patch and attached it. File Added: 1673757-1.diff ---------------------------------------------------------------------- Comment By: Paul Hankin (paulhankin) Date: 2007-03-10 18:01 Message: Logged In: YES user_id=1740099 Originator: NO Your change in Objects/stringobject.c and Objects/unicodeobject.c goes over the 79 character line limit. Otherwise looks ok - compiles, runs, tests look correct and pass. ---------------------------------------------------------------------- Comment By: Eric V. Smith (ericvsmith) Date: 2007-03-06 11:10 Message: Logged In: YES user_id=411198 Originator: YES Updated diff file attached, with correct filenames and with updated tests. File Added: 1673757.diff ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1673759&group_id=5470
_______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
