Patches item #1755206, was opened at 2007-07-17 02:46
Message generated for change (Settings changed) made by amauryf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1755206&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 3000
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Amaury Forgeot d'Arc (amauryf)
>Assigned to: Guido van Rossum (gvanrossum)
Summary: struni: corrections in ftplib

Initial Comment:
test_ftplib now passes, but it only tests socket timeouts...
My corrections were based on runs like:
python -m ftplib ftp.gnu.org -l emacs

Note: In this kind of code, byte objects make the code more difficult:
- it is easy to forget the b prefix 
eg:    resp[:3] in (b'250', '200')
- getitem does not return a single byte:
eg:    resp[0] == b'2'

Or should ftplib decode all the lines it receives?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1755206&group_id=5470
_______________________________________________
Patches mailing list
Patches@python.org
http://mail.python.org/mailman/listinfo/patches

Reply via email to