Patches item #1759016, was opened at 2007-07-23 12:23 Message generated for change (Comment added) made by gvanrossum You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1759016&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tests Group: Python 3000 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Joe Gregorio (jcgregorio) Assigned to: Nobody/Anonymous (nobody) Summary: pyexpat unit tests - str/uni branch Initial Comment: Fixes to module and unit tests so that unit tests pass. Changes: 1. Removed "returns_unicode" attribute, associated code in the module to support that attribute, and all tests associated with it. 2. Parsed data is now returned as unicode strings. 3. Changed input tests to use io.BytesIO instead of StringIO, to reflect the byte processing nature of expat. ---------------------------------------------------------------------- >Comment By: Guido van Rossum (gvanrossum) Date: 2007-07-23 13:00 Message: Logged In: YES user_id=6380 Originator: NO When trying to apply the patch I get: Hunk #14 FAILED at 878. 1 out of 21 hunks FAILED -- saving rejects to file Modules/pyexpat.c.rej Can you svn up, fix the patch, and upload it again? ---------------------------------------------------------------------- Comment By: Joe Gregorio (jcgregorio) Date: 2007-07-23 12:35 Message: Logged In: YES user_id=81604 Originator: YES Discussion of only processing bytes: http://mail.python.org/pipermail/python-3000/2007-July/008861.html Discussion of removing 'returns_unicode': http://mail.python.org/pipermail/python-3000/2007-July/008895.html ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1759016&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
