Patches item #1761803, was opened at 2007-07-27 15:57 Message generated for change (Comment added) made by ocean-city You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1761803&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Core (C code) Group: Python 2.6 Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Hirokazu Yamamoto (ocean-city) Assigned to: Mark Hammond (mhammond) Summary: Some fix abount _WIN32_WINNT Initial Comment: http://mail.python.org/pipermail/python-checkins/2007-July/061251.html Due to r56561 change, VC6 fails to compile Module/posixmodule.c, becaue Crypt API needs _WIN32_WINNT definition. I'll atach the fix patch. 1. Fix a typo in PC/pyconfig.h. 2. Still compile fails, because Py_BUILD_CORE seems not to be defined on VC6 build system. I greped, and found that it's only defined on VC8(PCBuild8/pythoncore/pythoncore.vcproj). Maybe it's right fix to define Py_BUILD_CORE on all platforms, but I don't know the meaning of this macro, so I simply reverted r55103 change which removed local _WIN32_WINNT definition in Module/posixmodule.c. ---------------------------------------------------------------------- >Comment By: Hirokazu Yamamoto (ocean-city) Date: 2007-07-30 10:48 Message: Logged In: YES user_id=1200846 Originator: YES Thank you, I confirmed your fix worked fine. ---------------------------------------------------------------------- Comment By: Mark Hammond (mhammond) Date: 2007-07-30 09:45 Message: Logged In: YES user_id=14198 Originator: NO This was my fault - Py_BUILD_CORE is defined in that same .h file - but after my new block which tested for it. I'd forgotten the build systems still define USE_DL_EXPORT instead of directly defining Py_BUILD_CORE and I should have checked. The error was compounded by the fact that a VC2003 build does *not* require these definitions. I can't see VC6 build files for the svn trunk, so I'm unable to test that posixmodule works with that compiler - but it *should* work, assuming my fix means that posixmodule will now see the #define in pyconfig.h Fixed in r56624 ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2007-07-28 20:43 Message: Logged In: YES user_id=21627 Originator: NO Mark, since this was your checkin: Can you take a look? If not, please unassign. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1761803&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
