Patches item #1755133, was opened at 2007-07-16 17:27
Message generated for change (Comment added) made by gvanrossum
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1755133&group_id=5470
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: Python 3000
>Status: Closed
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Hasan Diwan (hdiwan650)
>Assigned to: Guido van Rossum (gvanrossum)
Summary: urllib2 tests pass
Initial Comment:
Tests pass for urllib2
----------------------------------------------------------------------
>Comment By: Guido van Rossum (gvanrossum)
Date: 2007-08-03 15:21
Message:
Logged In: YES
user_id=6380
Originator: NO
A different patch, by Joe Gregorio, was committed that fixes this in
differently.
----------------------------------------------------------------------
Comment By: Guido van Rossum (gvanrossum)
Date: 2007-07-17 16:56
Message:
Logged In: YES
user_id=6380
Originator: NO
With the latest version I still get three errors:
test_basic_and_digest_auth_handlers, test_basic_auth,
test_proxy_basic_auth, all failing here:
File "Lib/test/test_urllib2.py", line 990, in _test_basic_auth
r = opener.open(request_url)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 374, in open
response = self._open(req, data)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 392, in _open
'_open', req)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 352, in _call_chain
result = func(*args)
File "Lib/test/test_urllib2.py", line 363, in http_open
"http", req, MockFile(), self.code, name, msg)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 412, in error
result = self._call_chain(*args)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 352, in _call_chain
result = func(*args)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 831, in http_error_407
authority, req, headers)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 795, in http_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
File "/usr/local/google/home/guido/python/py3k-struni/Lib/urllib2.py",
line 801, in retry_http_basic_auth
auth = 'Basic %s' % base64.b64encode(raw).strip()
TypeError: strip() takes exactly one argument (0 given)
Also:
(1) I'd like to see the interact_netscape call fixed rather than commented
out
(2) I wonder if urllib shouldn't use text strings instead of bytes for
headers and values.
----------------------------------------------------------------------
Comment By: Hasan Diwan (hdiwan650)
Date: 2007-07-16 18:19
Message:
Logged In: YES
user_id=1185570
Originator: YES
File Added: test_urllib2.pat
----------------------------------------------------------------------
Comment By: Hasan Diwan (hdiwan650)
Date: 2007-07-16 17:51
Message:
Logged In: YES
user_id=1185570
Originator: YES
File Added: test_urllib2.pat
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1755133&group_id=5470
_______________________________________________
Patches mailing list
Patches@python.org
http://mail.python.org/mailman/listinfo/patches
