Patches item #1768976, was opened at 2007-08-07 08:19 Message generated for change (Comment added) made by arsatiki You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1768976&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Macintosh Group: Python 3000 Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: Antti Rasinen (arsatiki) Assigned to: Neal Norwitz (nnorwitz) Summary: Fix for failing test_scriptpackages in py3k-struni Initial Comment: The test failed because the imported aetools-module compared types directly instead of using isinstance. Fixed that and removed from types import * as well. ---------------------------------------------------------------------- >Comment By: Antti Rasinen (arsatiki) Date: 2007-08-07 20:49 Message: Logged In: YES user_id=1862041 Originator: YES I re-examined the code again. The comments clearly state that it should be a four-byte element. I changed the isinstance-test to isinstance(signature, bytes) and the test passes, again. I have a fear that the tests do not actually cover that part of code. ---------------------------------------------------------------------- Comment By: Guido van Rossum (gvanrossum) Date: 2007-08-07 17:27 Message: Logged In: YES user_id=6380 Originator: NO FYI, test passes. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2007-08-07 08:42 Message: Logged In: YES user_id=33168 Originator: NO Thanks! I can't test this one right now, but it looks good. Committed revision 56791. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1768976&group_id=5470 _______________________________________________ Patches mailing list Patches@python.org http://mail.python.org/mailman/listinfo/patches
