Patches item #1774369, was opened at 2007-08-15 00:35
Message generated for change (Comment added) made by tiran
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1774369&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core (C code)
Group: Python 3000
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Christian Heimes (tiran)
Assigned to: Nobody/Anonymous (nobody)
Summary: Unify __builtins__ -> __builtin__

Initial Comment:
The patch renames __builtins__ to __builtin__ in the C and Python sources and 
renames builtins to builtin in the C code.

Missing:

 * documentation update
 * 2to3 fixer

----------------------------------------------------------------------

>Comment By: Christian Heimes (tiran)
Date: 2007-08-19 15:50

Message:
Logged In: YES 
user_id=560817
Originator: YES

Personally I prefer to have one and just one way to spell a variable. I'd
find it confusing to have __builtin__ (singular form) but a C variable
named builtins (plural form). I changed it for aesthetic and consistency
reasons. 

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2007-08-18 22:34

Message:
Logged In: YES 
user_id=6380
Originator: NO

Thanks!

(Though I wish you'd left the C variable names alone, the patch is
unnecessarily big this way.)

I am also wondering about some semantic endcases; in 2.x, it is *possible*
to have __builtin__ and __builtins__ point to different place, and I am
going to do some soul-searching to make sure that's not a loss of
functionality.

No need to update the patch, I just have to think about it some more.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1774369&group_id=5470
_______________________________________________
Patches mailing list
[email protected]
http://mail.python.org/mailman/listinfo/patches

Reply via email to