Patches item #2801674, was opened at 2009-06-05 13:43
Message generated for change (Tracker Item Submitted) made by dvdhrm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=504082&aid=2801674&group_id=63470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: u2.10.12
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David Herrmann (dvdhrm)
Assigned to: Nobody/Anonymous (nobody)
Summary: Remove FLAG_IPCHECK in IPcheck_disconnect

Initial Comment:
The ircu calls IPcheck_disconnect() only when he kills a client. Therefore, 
IPcheck_disconnect is the last IPcheck function
which is called on a client. However, this may change.
Therefore, why does IPcheck_disconnect() not remove the FLAG_IPCHECK flag from 
a client? The IPcheck_connect functions
set this flag, however, the removal is handled manually by the code. This is a 
bit inconsistent and calling ClearIPChecked() in
IPcheck_disconnect() would make the code clearer.

The problem is, calling any IPcheck_connect function after an 
IPcheck_disconnect() segfault because of an assertation.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=504082&aid=2801674&group_id=63470
_______________________________________________
Patches mailing list
[email protected]
http://undernet.sbg.org/mailman/listinfo/patches

Reply via email to