On Fri, Feb 11, 2011 at 09:13:26AM +0800, Jeremy Kerr wrote:
> Hi Dirk,
> 
> > The keyword 'blank' concerns only validation and does not change what
> > will be stored in the database.
> 
> mostly applied:
> 
> > -    hash = HashField(null = True, db_index = True)
> > +    hash = HashField(db_index=True ,null=True, blank=True)
> 
> Trying to sneak an index in, eh? :)

Yeah, except this pesky change-history in the django admin interface ;)

> Although this is probably a good idea, do you have a particular requirement 
> (or data) for this change?

No, just when saving a pull request through the admin interface I would
have to fake a hash.

If it's ok, and you apply, maybe fix the comma-space order in the new
line.

-- 
Greetings,
Dirk
_______________________________________________
Patchwork mailing list
[email protected]
https://lists.ozlabs.org/listinfo/patchwork

Reply via email to