Em 18-03-2011 19:13, Guilherme Salgado escreveu: > On Fri, 2011-03-18 at 22:43 +0100, Peter Maydell wrote: >> On 18 March 2011 22:33, Guilherme Salgado <[email protected]> >> wrote: >>> On Fri, 2011-03-18 at 09:23 -0300, Mauro Carvalho Chehab wrote: >>>> Em 17-03-2011 19:20, Peter Maydell escreveu: >>>>> For completeness, should we support the git am "Subject: can >>>>> be at the start of the body" syntax too? >>>> >>>> I think that, if such support is added on patchwork (both from: and >>>> subject: >>>> replacements), the better would be to output them as a patchwork-specific >>>> meta-data at the emails, like: >>> >>> We should store them in the DB in a structured fashion, but once we have >>> that it's trivial to include it in the mbox file that patchwork provides >>> for every patch, which i think is what you want? >> >> Ew. The mbox should always be the mail as received by patchwork, >> in my opinion, not some reconstituted near-equivalent. I would have thought >> the main reason for patchwork to parse these From:-lines-in-body would >> be so its web display could get the author right. > > My main reason for parsing the From: lines in the body is to display > them in the web UI, but there's no reason why we can't use the data for > other use cases that people might have. > (FWIW, Patchwork currently reconstructs the mbox based on the data > stored in the DB)
Having this parsed and displayed properly at the web UI seems a good idea. >> I want to be able to download the mbox file and run 'git am' on it >> and have it do the right thing. If you remove the From lines from >> the body and turn them into patchwork-specific headers you break >> that use case. > > Maybe I misunderstood what Mauro meant, but I was not thinking of > removing the From: lines from the body -- just amending the body (or the > headers) to include the data in a way that's easier to parse. Although > I see that amending the body may not be a good idea as it could break > existing tools even if we leave the 'From:' lines untouched. Yes, that's my point: changing it may break existing tools. If you add a new patchwork metadata in the email header part, proabably, this won't hurt. Cheers, Mauro. _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
