On Tue, 2011-04-12 at 09:53 +0800, Jeremy Kerr wrote: > Hi Guilherme, > > > Another thing I've just noticed we'll have to keep in mind is that in > > these per-project lists, users won't be able to do mass-state-changes > > unless they're the maintainers of the project in question. We could > > change generic_list() to behave differently and always include the > > state-changing form, but this seems to me like yet another indication > > that generic_list() may not be the appropriate thing to use here. > > That would indicate to me that we should update generic_list to handle > these cases properly. > > What we could do: if there are editable patches in the list, then > include the checkbox-per-patch column (with checkboxed disabled for > non-editable patches), and include the state-changing form. Otherwise, > just leave it as a read-only view.
I was going to give this a try but then I realized that the checkboxes are also used by the bundle form, which doesn't require patch edit rights. IOW, doing this change means people would lose the ability to bundle patches on which they don't have edit rights, which I think is not desirable, right? -- Guilherme Salgado <https://launchpad.net/~salgado>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
