see http://patchwork.ozlabs.org/patch/163063/

Is there something wrong in my patch?  It's generated by git and I
didn't touch it. Below is the patch.

Signed-off-by: Hong Zhiguo <[email protected]>
---
 drivers/net/macvtap.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 2ee56de..0737bd4 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -847,13 +847,12 @@ static ssize_t macvtap_do_read(struct
macvtap_queue *q, struct kiocb *iocb,
                               const struct iovec *iv, unsigned long len,
                               int noblock)
 {
-       DECLARE_WAITQUEUE(wait, current);
+       DEFINE_WAIT(wait);
        struct sk_buff *skb;
        ssize_t ret = 0;

-       add_wait_queue(sk_sleep(&q->sk), &wait);
        while (len) {
-               current->state = TASK_INTERRUPTIBLE;
+               prepare_to_wait(sk_sleep(&q->sk), &wait, TASK_INTERRUPTIBLE);

                /* Read frames from the queue */
                skb = skb_dequeue(&q->sk.sk_receive_queue);
@@ -875,8 +874,7 @@ static ssize_t macvtap_do_read(struct
macvtap_queue *q, struct kiocb *iocb,
                break;
        }

-       current->state = TASK_RUNNING;
-       remove_wait_queue(sk_sleep(&q->sk), &wait);
+       finish_wait(sk_sleep(&q->sk), &wait);
        return ret;
 }

-- 
1.7.4.1
_______________________________________________
Patchwork mailing list
[email protected]
https://lists.ozlabs.org/listinfo/patchwork

Reply via email to