2015-07-29 09:58, Finucane, Stephen: > > 2015-07-29 09:58, Stephen Finucane: > > > +class Status(models.Model): > > > + """Status for a patch. > > > + > > > + Statuses define a state for patches. This is useful, for example, > > > + when using a continuous integration (CI) system to test patches. > > > + """ > > > > There is already "class State" associated to "class Patch". > > Don't you think TestStatus would be a better name? > > I've discussed this with a few folks already. The 'Status.state' naming is > inconvenient,
Having State and Status is confusing. > but I can't think of a better word to represent this. > As for the whole model, I think we shouldn't necessarily restrict this > to test results: you could have a license check job, for example. I think a license check is a test. The values for Status are Success/Warning/Failure. They are results of a test. > I did consider renaming the model 'services' (this is the terminology the > rather sweet 'review.ninja' app uses) but I think 'status' is still > perfectly suitable TBH. Thoughts? _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
