On Tue, Aug 25, 2015 at 10:30:32AM +0100, Finucane, Stephen wrote:
> > +table#patchlist > tbody > tr > td.tag-A {
> > + text-align: center;
> > + background-color: #bdecb6;
> > +}
> > +
> > +table#patchlist > tbody > tr > td.tag-R {
> > + text-align: center;
> > + background-color: #c3fdb8;
> > +}
> > +
> > +table#patchlist > tbody > tr > td.tag-T {
> > + text-align: center;
> > + background-color: #b4cfec;
> > +}
>
> This assumes you only have Acked/Reviewed/Tested-by tags. However, it
> is possible to add additional tags as required so this won't scale.
> Maybe it's not an issue?
Well, there's a lot to talk about with tags. Associating a color with
the tag (in the db then) makes some sense. That's something that can be
changed in the future though and I didn't want to introduce db changes
before we have sorted out the pending patches touching the db.
One note is that "genericity" is already biting us a bit in the patch
state, it's a fine idea, but in practice all known patchwork instances
seem to work with the same list of states, so all it does is introducing
more complexity from my point of view.
For tags though, I thing the idea can be extended quite a bit, but
that's a whole different story.
> In any case, move 'text-align' into 'table#patchlist > tbody > tr' -
> no point in duplicating it.
I don't believe so, I don't want to center all the <td> in that table,
just the ones with those clases.
--
Damien
_______________________________________________
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
