On Thu, Sep 10, 2015 at 05:24:47PM +0100, Finucane, Stephen wrote: > > On Thu, Sep 10, 2015 at 05:17:55PM +0100, Finucane, Stephen wrote: > > > > All 'Comments' are stored the same way in the db, but I believe it's > > > > worth making the distinction between introducing what the patch does > > and > > > > eventual review comments. > > > > > > > > v2: Use two new Patch methods to retrieve the commit message and the > > > > other comments (called answers here) (Jeremy Kerr) > > > > > > > > Signed-off-by: Damien Lespiau <damien.lesp...@intel.com> > > > > > > How about using tabs to separate the patch from the comments/commit > > message, a lá GitHub? > > > > That's definitely a possibility, design is all about iterations really > > and this initial series definitely can do with more iterations. > > Good stuff. Parsing the patch to split out the changes to different > files (once again, a lá GitHub) would also be a nice touch. See here: > > > https://github.com/naoyukik/CTags/commit/756bcbe63234a559bd0ee66690811589ea88929d > > Side note: I've some work done on a split view, which I find easier to > read than unified view (especially when you've a large number of > changed lines). Both of these ideas can wait - I think the tabs idea > is a more immediate fix (i.e. for v3 of this series).
Actually, if given a choice, I'd rather land this as is and then think about the next iteration. The current state is, IMHO, a bit better than the current design. I'd be fairly cautious to not have big series in flight for too long as it means rebasing down the line and makes it unlikely to ever land. -- Damien _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
