Previously this returned a list. However, a QuerySet is more flexible and is required to provide a generic check endpoint at some point in the future.
Signed-off-by: Stephen Finucane <[email protected]> Reviewed-by: Andy Doan <[email protected]> --- patchwork/models.py | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/patchwork/models.py b/patchwork/models.py index 4d92db3..eb12635 100644 --- a/patchwork/models.py +++ b/patchwork/models.py @@ -425,17 +425,22 @@ class Patch(Submission): type. """ unique = {} + duplicates = [] for check in self.check_set.all(): ctx = check.context - # recheck condition - ignore the older result - if ctx in unique and unique[ctx].date > check.date: - continue + if ctx in unique: + # recheck condition - ignore the older result + if unique[ctx].date > check.date: + duplicates.append(check.id) + continue + duplicates.append(unique[ctx].id) unique[ctx] = check - return list(unique.values()) + # filter out the "duplicates" or older, now-invalid results + return self.check_set.all().exclude(id__in=duplicates) @property def check_count(self): -- 1.7.4.1 _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
