On 30 Jun 10:38, Finucane, Stephen wrote: > On 29 Jun 12:12, Andy Doan wrote: > > On 06/23/2016 04:53 PM, Stephen Finucane wrote: > > >There are a couple of issues with the tests that need resolving. > > > > > >* The tests make extensive use of the models, as one would expect. > > > However, how these models are created varies significantly. In a lot > > > of cases, "defaults" are used, yet in other cases, new instances are > > > created from scratch. Standardize the creation of these tests. > > >* All of the tests are named using camelcase. There's nothing to be > > > done about the existing unittest code, but there's no reason to use > > > this for custom test code. Convert to underscore case. > > >* A lot of tests use hardcoded URLs, which makes it difficult to > > > modify urls.py in a deployment. > > >* Some of the tests are grouped, or named, funnily. > > >* There is some code that simply does nothing, particularly around the > > > areas of tearDown. > > > > I've reviewed and tested at home. One thing I noticed was there was > > no patch 23 in this set. Was that intentional, or did it get lost? > > It appears to have been dropped. I'll avoid merging this and resend it: > hopefully it arrives this time.
Merged patches 1-22. 23-25 and some additonal patches have been sent as a new series. Stephen _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
