On 23/11/16 18:01, Andrew Donnellan wrote:
When generating an mbox for a patch with tags in the original commit message, e.g.:Example patch This patch is awesome! Signed-off-by: Andrew Donnellan <[email protected]> Acked-by: Russell Currey <[email protected]> the tags from the original email are duplicated: Example patch This patch is awesome! Signed-off-by: Andrew Donnellan <[email protected]> Acked-by: Russell Currey <[email protected]> Signed-off-by: Andrew Donnellan <[email protected]> Acked-by: Russell Currey <[email protected]> It appears that during the refactoring in ef56359fb776 ("models: Merge patch and first comment"), we added a call to patch.patch_responses() to extract the tags from the initial patch email, which we then append to the patch email body... which already has the tags in it. Remove the unnecessary append of patch.patch_responses when generating an mbox. Fixes: ef56359fb776 ("models: Merge patch and first comment") Reported-by: Russell Currey <[email protected]> Signed-off-by: Andrew Donnellan <[email protected]> --- Stephen, does this look correct?
Would it be helpful to add a test that compares full mbox output to catch stuff like this?
-- Andrew Donnellan OzLabs, ADL Canberra [email protected] IBM Australia Limited _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
