On Mon, 2016-11-21 at 14:36 +1100, Daniel Axtens wrote: > Hi Stephen, > > > > > This is one of the most useful fields to allow editing of via the > > API. > > Make it so. > > Please could you revise this commit message? > > We seem to already have tests that check if you can successfully > PATCH > the state of a patch. This patch can't be making that editable if it > already is editable.
Commit message revised. As said in the reply to Andy's mail, the test was broken and didn't validate that we could actually change the field - only that a HTTP 200 response code would be returned. That, and the test, are both updated now. > You also change the way you interact with the state of a patch. I > quite > like the change you've made, but the commit message should explain it > (and that it's a breaking change!). Good point. Done. Stephen _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
