Hi Stephen, I'm quite happy with this series!
Reviewed-by: Daniel Axtens <[email protected]> A minor thought: > +[testenv:bashate] > +deps = bashate>=0.5,<0.6 > +whitelist_externals = bash > +commands = > + bash -c "find {toxinidir} \ > + -not \( -type d -name .?\* -prune \) \ > + -not \( -type d -name db -prune \) \ > + -name \*.sh -print | xargs bashate" > + We could install shellcheck in the docker container and make it usable that way? No strong feelings, just a thought. Also, should this be a default check? I assume it's quite quick. Regards, Daniel _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
