Hi Stephen, > I haven't seen it either, but I haven't reset in a while. I've had a > few reports of this so it's definitely an issue.
Yeah, I believe it, especially seeing the similarities. >> What's the expected db overhead of doing this? It's one extra call >> (possibly cached) per instance of StateField? > > I don't think there'll be any additional overhead, seeing as we call > 'select_related' as part of the queryset for that API [1] Cool. >> I thought GitHub parsed on "Closes:", but I could be wrong... > > It parses 'Closes #67', e.g. no colon. I'm happy to keep the colon, > close the bug manually, and satisfy the side of me that insists tags > have colons after them :) Ahahah that sucks! My preference would be the colon too, but I'm not the maintainer - if you want to get them autoclosed that's fine with me :) > > Oops, good spot. Those lines can go, as they're remnants of an attempt > to load the STATE_MAP and provide a regression test (which doesn't > appear to be possible). Cool - with that and a slightly more targeted doc-string, Reviewed-by: Daniel Axtens <[email protected]> Regards, Daniel _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
