On Thu, 2017-04-06 at 07:04 +1000, Daniel Axtens wrote: > Stephen Finucane <[email protected]> writes: > > > On Wed, 2017-04-05 at 14:29 +1000, Daniel Axtens wrote: > > > Hi Stephen, > > > > > > Thanks for doing all of these - I will test them soon. > > > > No problem. Do note that there's an apparent issue with DRF 3.4 and > > Django 1.10. It _should_ work, but it gives an odd warning. You can > > probably ignore that particular combination given the age gap > > between > > them. > > > > > > I'm not sure about this one: it's a _lot_ of extra testing that > > > > I'm > > > > not > > > > so sure people will run. I wonder if it's even worth it? > > > > Perhaps > > > > Travis > > > > could test using system packages in addition to pip? > > > > > > I have a partial patch in this direction - I suggest adding > > > things > > > like > > > py{27,35}-{xenial,jessie,etc} that install the versions known to > > > be > > > available on those platforms. > > > > Do be aware that those packages frequently carry backports from > > newer > > versions and might be different to the version found in pip. > > Testing > > with _actual_ system packages would be a far better indicator. > > > > Also - I ran these tests last night and it took over an hour. > > That's a > > bit long for anything non-automated, I think. Must find a better > > way. > > OK - I have been building docker files for production deployment*: > they use > the system packages. I will rework those and send them.
Sounds like a plan. I'm not sure if this should be in the Patchwork project or maintained separately though? > Note that I haven't been able to find a system package for > drf-nested-routers. Perhaps we could 'vendor' that? This dependency isn't needed any more - what made you think it was? Stephen > > Regards, > Daniel > > * see patchwork.dja.id.au PS: Very nice :) > > > > Cheers, > > Stephen _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
