On Wed, 2017-06-14 at 14:16 -0400, Aaron Conole wrote: > Aaron Conole <[email protected]> writes: > > > This commit allows users of the REST API to query for events based on > > the date field. This will allow utility writers to select a smaller > > subset of events when polling. > > > > Signed-off-by: Aaron Conole <[email protected]>
I think I missed this initially because I'd intended to use cursor-based pagination [1] for '/events'. Cursor-based pagination would be beneficial in so far as it allows us to grab a pseudo-permalink to page of events, which isn't possible with page number-based pagination because the page numbers can change way to darn quick. However, it does make '/events' unique in how it does pagination. I can go either way with this, and can submit an RFC for this this evening, if it would help to compare the two. > > --- > > It should be noted that my motivation for this is to implement a git-pw > event poll command for CI integration. Hmm, so I'll admit I'm not overly fond of this idea. I'm trying to keep git-pw as a client side tool for git-patchwork interaction and not a catch-all application for all things Patchwork like pwclient currently is. "Create a check" doesn't sound like something Acme developer would be doing from within their Git repo. > If you think there's a better way of achieving this, let me know. Any chance you could keep this as a separate tool? I'd be happy to spin out some of the 'git-pw' code into a 'patchwork-api' library, if that would help (though there really isn't much to spin out). Alternatively, some of the folks here were working on a "snowpatch" tool. I've no idea how far along it is nor how it works, but it could be a good option if it's still progressing. Stephen PS: I published a (now rather outdated) outdated blog [2] and talk [3] on how to do basic interaction between the REST API and Jenkins a while back. Might be worth looking at if you haven't seen them already. [1] http://www.django-rest-framework.org/api-guide/pagination/#cursorpagination [2] https://that.guru/blog/patchwork-and-ci-in-a-tree/ [3] https://speakerdeck.com/stephenfin/mailing-list-meet-ci _______________________________________________ Patchwork mailing list [email protected] https://lists.ozlabs.org/listinfo/patchwork
