On Mon, 2018-04-09 at 09:29 -0400, Veronika Kabatova wrote: > ----- Original Message ----- > > From: "Stephen Finucane" <step...@that.guru> > > To: vkaba...@redhat.com, firstname.lastname@example.org > > Sent: Monday, April 9, 2018 3:02:57 PM > > Subject: Re: [PATCH] Add comments REST API > > > > On Fri, 2018-03-23 at 13:33 +0100, vkaba...@redhat.com wrote: > > > From: Veronika Kabatova <vkaba...@redhat.com> > > > > > > Signed-off-by: Veronika Kabatova <vkaba...@redhat.com> > > Thanks for feedback! > > > Looks pretty good. As you note, it does need some tests. I'm also > > curious about the idea of nesting this under the patches endpoint. Let > > me know what you think. > > > > Hmm, that would require the same change for cover letters too. How do > you imagine it? Having all related comments under the detailed patch or > cover, or something else?
Indeed. I'd expect all replies to a given patch to be under that patch and so on. This is what we present in the web UI so it probably makes sense to do the same for the REST API. Unless there's a strong reason _not_ to, this is the way I'd go, yeah. > I opted for separate API because some people may not care about comments > (since AFAIK noone requested it yet), but we very much do. At the same > time I didn't want to push our needs on others. If you don't think it's > an issue I can rework this and put it under the patch/cover endpoints. Yup, I didn't do it because I wasn't sure how helpful it was. I'm a-ok adding it though so go for it. Stephen PS: You should probably put a 'comments' url in the 'patches' and 'covers' resources, similar to what we do for 'checks' of 'patches'. _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork