On Fri, 2019-05-03 at 16:14 +1000, Daniel Axtens wrote: > Andrew Donnellan <andrew.donnel...@au1.ibm.com> writes: > > > On 1/5/19 2:35 pm, Russell Currey wrote: > > > psycopg2-binary fails if pg_config isn't installed, which is provided by > > > libpq-dev. > > > > > > This seems strange to me since psycopg2-binary suggests that > > > you use psycopg2-binary instead (of itself) if you don't want to build > > > psycopg2 so you wouldn't need pg_config, which is very confusing. > > > > > > It's possible that psycopg2-binary only needs to compile itself on > > > non-x86 platforms, since I hit this on ppc64le. > > > > > > Anyway, it works when this is added. > > > > I don't think there is a binary psycopg2-binary build for anything other > > than i686/x86_64? > > Right, yeah that would probably explain it. Given that libpq-dev just > lives in the docker image, I don't think there's any harm here other > than a slightly larger download when doing your first image build. I > think we can live with that for cross-platform support. > > Applied.
Given that we've done this, we should probably switch back to the non- binary package since this isn't necessary now. Stephen > Daniel > > > > Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> > > > > > Signed-off-by: Russell Currey <rus...@russell.cc> > > > --- > > > tools/docker/Dockerfile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile > > > index b9ecdb5..eef40e4 100644 > > > --- a/tools/docker/Dockerfile > > > +++ b/tools/docker/Dockerfile > > > @@ -26,7 +26,7 @@ RUN apt-get update -qq && \ > > > python3.5-dev python3-pip python3-setuptools python3-wheel \ > > > python3.4-dev findutils=4.4.2-7 python3.6-dev \ > > > libmysqlclient-dev mysql-client curl unzip build-essential \ > > > - git postgresql-client tzdata > > > + git postgresql-client tzdata libpq-dev > > > > > > # User > > > RUN useradd --uid=$UID --create-home patchwork > > > > > > > -- > > Andrew Donnellan OzLabs, ADL Canberra > > andrew.donnel...@au1.ibm.com IBM Australia Limited > > > > _______________________________________________ > > Patchwork mailing list > > Patchwork@lists.ozlabs.org > > https://lists.ozlabs.org/listinfo/patchwork > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
