Currently, there is no state or status associated with patch comments. In particular, knowing whether a comment on a patch is addressed is useful for transparency and accountability in the review and contribution process. This series adds labels to comments to show whether they are “Addressed” or “Unaddressed”. Also, the addressed status of a comment can be manually changed given the required permissions to edit a patch. A future feature that would be useful to implement with this new feature is the ability to automatically add unaddressed comments to a user’s TODO page.
Something important to note is that this patch series relies on the JS cookie library [1] and rest.js file [2], both introduced in my previous patch series. Also, the patch series is a RFC because tests for the new /comments/<comment_id> endpoint need to be added as well as release notes. For the first patch, the addressed field is added to the data model and a new endpoint for the REST API to work with a specific comment is added as well. For the second patch, the comment addressed status label and button to change the addressed status are added with styling. For the third patch, the REST API call is added when the buttons are clicked to change the addressed status of a comment. Also, the UI is set to update accordingly. [1] https://lists.ozlabs.org/pipermail/patchwork/2021-July/006969.html [2] https://lists.ozlabs.org/pipermail/patchwork/2021-July/006972.html Raxel Gutierrez (3): api: add addressed field and detail endpoint for patch comments patch-detail: add label and button for comment addressed status patch-detail: add functionality for comment status updates htdocs/css/style.css | 55 ++++++- htdocs/js/submission.js | 52 +++++++ patchwork/api/base.py | 24 ++- patchwork/api/check.py | 21 +-- patchwork/api/comment.py | 76 +++++++-- .../migrations/0045_patchcomment_addressed.py | 18 +++ patchwork/models.py | 3 +- patchwork/templates/patchwork/submission.html | 146 +++++++++++------- patchwork/urls.py | 7 +- patchwork/views/patch.py | 1 + templates/base.html | 2 +- 11 files changed, 306 insertions(+), 99 deletions(-) create mode 100644 htdocs/js/submission.js create mode 100644 patchwork/migrations/0045_patchcomment_addressed.py -- 2.32.0.432.gabb21c7263-goog _______________________________________________ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
